Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled dd_network; fix log message; fix handling of helper errors #3107

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix unhandled dd_network; fix log message; fix handling of helper errors #3107

merged 1 commit into from
Feb 26, 2025
+51 −10

Conversation

cataphract
Copy link
Contributor

Description

  • Fix unhandled dd_network in newer calls (dd_network not handled)
  • Fix log message (signed char -> integer promotion when printing)
  • Fix handling of helper errors (extension took as errors messages with size 1 which were then leaked; actually helper sends an "error" message)

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner February 25, 2025 17:23
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.97%. Comparing base (8fac8d9) to head (71f4156).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
appsec/src/extension/request_lifecycle.c 0.00% 4 Missing ⚠️
appsec/src/extension/user_tracking.c 0.00% 2 Missing and 1 partial ⚠️
appsec/src/extension/commands_helpers.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3107      +/-   ##
============================================
- Coverage     74.74%   72.97%   -1.78%     
  Complexity     2790     2790              
============================================
  Files           112      139      +27     
  Lines         11039    15280    +4241     
  Branches          0     1047    +1047     
============================================
+ Hits           8251    11150    +2899     
- Misses         2788     3578     +790     
- Partials          0      552     +552
Flag Coverage Δ
appsec-extension 68.35% <20.00%> (?)
tracer-php 74.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/network.c 44.69% <ø> (ø)
appsec/src/extension/commands_helpers.c 63.36% <66.66%> (ø)
appsec/src/extension/user_tracking.c 68.80% <0.00%> (ø)
appsec/src/extension/request_lifecycle.c 61.05% <0.00%> (ø)

... and 23 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fac8d9...71f4156. Read the comment docs.

@cataphract cataphract merged commit 18fa3c5 into master Feb 26, 2025
730 of 761 checks passed
@cataphract cataphract deleted the glopes/try-fix-bad-connection-state branch February 26, 2025 16:25
@github-actions github-actions bot added this to the 1.8.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

@estringana estringana estringana approved these changes

Assignees
No one assigned
Labels
area:asm tracing
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cataphract @codecov-commenter @Anilm3 @estringana